Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trigger_observers should operate on slices of data #14333

Closed
alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #14354
Closed

trigger_observers should operate on slices of data #14333

alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #14354
Labels
A-ECS Entities, components, systems, and events A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Milestone
0.15

Comments

@alice-i-cecile
Copy link
Member

trigger_observers over to slices rather than iterators, to match the new version of trigger_observers_with_data.

Originally posted by @NthTensor in #13991 (comment)
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jul 15, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Jul 15, 2024
@alice-i-cecile alice-i-cecile moved this to Active: engine observers and hooks in Alice's Work Planning Jul 15, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Picking Pointing at and selecting objects of all sorts labels Jul 15, 2024
@mnmaita mnmaita mentioned this issue Jul 16, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 17, 2024
@mnmaita
Update trigger_observers to operate over slices of data (#14354)
72e7a4f 
# Objective

- Fixes #14333 

## Solution

- Updated `trigger_observers` signature to operate over a slice instead
of an `Iterator`.
- Updated calls to `trigger_observers` to match the new signature.

---

## Migration Guide

- TBD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
Alice's Work Planning
Archived in project
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Update trigger_observers to operate over slices of data mnmaita/bevy
1 participant
@alice-i-cecile