Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubbling observers Traversal should use QueryData #14331

Closed
alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #15385
Closed

Bubbling observers Traversal should use QueryData #14331

alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #15385
Labels
A-ECS Entities, components, systems, and events A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Milestone
0.15

Comments

@alice-i-cecile
Copy link
Member

  • Traversal should be changed to use QueryData as described here.

Originally posted by @NthTensor in #13991 (comment)
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Jul 15, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Jul 15, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Picking Pointing at and selecting objects of all sorts labels Jul 15, 2024
@BenjaminBrienen BenjaminBrienen mentioned this issue Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@BenjaminBrienen @ItsDoot
Bubbling observers traversal should use query data (#15385)
27bea6a 
# Objective

Fixes #14331

## Solution

- Make `Traversal` a subtrait of `ReadOnlyQueryData`
- Update implementations and usages

## Testing

- Updated unit tests

## Migration Guide

Update implementations of `Traversal`.

---------

Co-authored-by: Christian Hughes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Picking Pointing at and selecting objects of all sorts C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Bubbling observers traversal should use query data BenjaminBrienen/bevy
1 participant
@alice-i-cecile