Rename empty and provide variant for TRUE

crates/bevy_ecs/src/query/access.rs

@@ -336,11 +336,7 @@ pub struct FilteredAccess<T: SparseSetIndex> {
 
 impl<T: SparseSetIndex> Default for FilteredAccess<T> {
     fn default() -> Self {
-        Self {
-            access: Access::default(),
-            required: FixedBitSet::default(),
-            filter_sets: vec![AccessFilters::default()],
-        }
+        Self::matches_everything()
     }
 }
 
@@ -353,9 +349,19 @@ impl<T: SparseSetIndex> From<FilteredAccess<T>> for FilteredAccessSet<T> {
 }
 
 impl<T: SparseSetIndex> FilteredAccess<T> {
-    /// Returns a `FilteredAccess` with no access and matching nothing.
+    /// Returns a `FilteredAccess` which has no access and matches everything.
+    /// This is the equivalent of a `TRUE` logic atom.
+    pub fn matches_everything() -> Self {
+        Self {
+            access: Access::default(),
+            required: FixedBitSet::default(),
+            filter_sets: vec![AccessFilters::default()],
+        }
+    }
+
+    /// Returns a `FilteredAccess` which has no access and matches nothing.
     /// This is the equivalent of a `FALSE` logic atom.
-    pub fn empty() -> Self {
+    pub fn matches_nothing() -> Self {
         Self {
             access: Access::default(),
             required: FixedBitSet::default(),

crates/bevy_ecs/src/query/fetch.rs

@@ -1865,7 +1865,7 @@ macro_rules! impl_anytuple_fetch {
                 // update the filters (Or<(With<$name>,)>)
                 let ($($name,)*) = state;
 
-                let mut _new_access = FilteredAccess::empty();
+                let mut _new_access = FilteredAccess::matches_nothing();
 
                 $(
                     // Create an intermediate because `access`'s value needs to be preserved

crates/bevy_ecs/src/query/filter.rs

@@ -443,7 +443,7 @@ macro_rules! impl_or_query_filter {
             fn update_component_access(state: &Self::State, access: &mut FilteredAccess<ComponentId>) {
                 let ($($filter,)*) = state;
 
-                let mut _new_access = FilteredAccess::empty();
+                let mut _new_access = FilteredAccess::matches_nothing();
 
                 $(
                     // Create an intermediate because `access`'s value needs to be preserved