[Merged by Bors] - Improve example page #350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
doup
commented
Apr 17, 2022
doup
commented
- This doesn't change the listing layout, but improves the sidebar category labels
- Tweaks example generation script to include labels for categories instead of using folder name
- Tweak single example page layout
alice-i-cecile
approved these changes
Apr 17, 2022
|
@cart should we have an |
mockersf
approved these changes
Apr 17, 2022
|
@doup this is still a draft; is there anything else you want to tackle before we merge this? |
|
I left this as a draft as I noticed that BevyMark isn't loading (see #351). But that's already a prod issue and can be tackled on another PR. So marking this as "ready for review". |
|
bors r+ |
|
Canceled. |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2022
- This doesn't change the listing layout, **but** improves the sidebar category labels - Tweaks example generation script to include labels for categories instead of using folder name - Tweak single example page layout <img width="209" alt="image" src="https://user-images.githubusercontent.com/188612/163731632-3abf4e78-31a3-4288-a5f3-24363c62b3bd.png"> <img width="843" alt="image" src="https://user-images.githubusercontent.com/188612/163731643-012820a0-377b-4bc3-a7e4-567081b807be.png"> <img width="354" alt="image" src="https://user-images.githubusercontent.com/188612/163731664-9b7d9cac-4e35-4aa0-92ef-17bf7b0f32fc.png">
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
|
Just wanted to swing by and say that this was really well done. Feels very polished! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.