Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble and trouble: release notes for bubbling observers #1823

Merged

Conversation

alice-i-cecile
Copy link
Member

Fixes #1657.

Copy link
Contributor

@BenjaminBrienen BenjaminBrienen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good!

Co-authored-by: Benjamin Brienen <[email protected]>
Copy link
Member

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing credit for @NthTensor?.I seem to recall he drove most of this work, though I might be misremembering.

@alice-i-cecile
Copy link
Member Author

Nth is listed as the author here, which is the primary credit :D

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 20, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Nov 20, 2024
Merged via the queue into bevyengine:main with commit f80436c Nov 20, 2024
10 checks passed
@alice-i-cecile alice-i-cecile deleted the double-double-bubble-and-trouble branch November 20, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Release-Notes S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write release notes for PR #13991: Minimal Bubbling Observers
3 participants