Clarify Texture Atlas rework migration guide
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 19, 2024
rparrett
suggested changes
Feb 19, 2024
There was a problem hiding this comment.
I can't make a specific suggestion right now, but the first paragraph has some typos / grammatical errors and could use a closer look.
Just some general feedback:
Overall in my notes I tried to lay it out like
Thingwas removed and hadAandB
- Where
Acan now be found- Where
Bcan now be found
Totally fine with rewriting those bullet points as a paragraph, but a lot of the language in the current text in this PR is pretty redundant which makes the changes hard to follow for me.
rparrett
approved these changes
Feb 20, 2024
Probably a good idea to add these to the Migration Guide so that folks know what has broken beyond the basics.
TrialDragon
added
the
S-Ready-For-Final-Review
rparrett
reviewed
Feb 20, 2024
TrialDragon
removed
the
S-Ready-For-Final-Review
TrialDragon
added
the
S-Ready-For-Final-Review
|
Okay, should be good to go now. This technically mentions changes from later PRs since they changed the same API slightly, building off of this one (then poorly documented it in their migration guides such that it probably wouldn't be seen). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the
Texture Atlas reworkmigration guide. Uses @rparrett's migration guide notes and bevyengine/bevy#5103 's change log as a base.Resolves #1025