[Merged by Bors] - add bevy_mod_ui_texture_atlas_image #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
|
hello! you should know that your image will be displayed at https://bevyengine.org/assets/, and it currently doesn't have the best ratio |
|
bors r- |
|
Canceled. |
Yes, you are right , I changed it. |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
yopox
pushed a commit
to yopox/bevy-assets
that referenced
this pull request
Oct 5, 2022
bors bot
pushed a commit
to bevyengine/bevy-website
that referenced
this pull request
Jan 31, 2023
Updating this old code on top of the recent improvements to the validator. Some previous discussion in #443 Some recent motivation in [#253](bevyengine/bevy-assets#253) ## Objective - Shorten the feedback loop for users submitting their projects to `bevy_assets` - Help maintainers enforce restrictions related to image size - ~~Improve the overall look and feel of the assets page by enforcing a reasonable aspect ratio~~ - Improve the performance of the assets page and reduce the repository size by enforcing a maximum file size - Make validation errors output a little more clear for users ## Example Output Note: Some of these validations are no longer present in this PR. ``` Fish Fight: Punchy Image dimensions must not exceed 1000x1000 px. Image aspect ratio must be between 1 and 2. taipo Description must be at most 100 chars in length. Image file not found. Bevy Combat Image file must be at most 1000000 bytes. Typey Birb Image aspect ratio must be between 1 and 2. Cheaters Never Win Image dimensions must not exceed 1000x1000 px. Image aspect ratio must be between 1 and 2. Error: 28 asset(s) are invalid. ``` ## Discussion Points This is currently a draft because many existing images do not currently meet these restrictions. For file size restrictions, we could manually fix up the files. But for image aspect ratio, I think we would need to find a way to "grandfather in" the old images. I contemplated a static list of grandfathered assets, but that would prevent validations from working if users attempt to update those in the future. Also, see #448 where we decided to use a single aspect ratio on the website. If that were fixed, we might want to rework the some of the validations like - Enforce a fixed image size rather than a maximum - Remove the separate aspect ratio check all-together The current file size limit in the PR seems clearly too large. I think something like 250kb would be more appropriate, but that would require a lot more work on existing assets.
bors bot
pushed a commit
to bevyengine/bevy-website
that referenced
this pull request
Jan 31, 2023
Updating this old code on top of the recent improvements to the validator. Some previous discussion in #443 Some recent motivation in [#253](bevyengine/bevy-assets#253) ## Objective - Shorten the feedback loop for users submitting their projects to `bevy_assets` - Help maintainers enforce restrictions related to image size - ~~Improve the overall look and feel of the assets page by enforcing a reasonable aspect ratio~~ - Improve the performance of the assets page and reduce the repository size by enforcing a maximum file size - Make validation errors output a little more clear for users ## Example Output Note: Some of these validations are no longer present in this PR. ``` Fish Fight: Punchy Image dimensions must not exceed 1000x1000 px. Image aspect ratio must be between 1 and 2. taipo Description must be at most 100 chars in length. Image file not found. Bevy Combat Image file must be at most 1000000 bytes. Typey Birb Image aspect ratio must be between 1 and 2. Cheaters Never Win Image dimensions must not exceed 1000x1000 px. Image aspect ratio must be between 1 and 2. Error: 28 asset(s) are invalid. ``` ## Discussion Points This is currently a draft because many existing images do not currently meet these restrictions. For file size restrictions, we could manually fix up the files. But for image aspect ratio, I think we would need to find a way to "grandfather in" the old images. I contemplated a static list of grandfathered assets, but that would prevent validations from working if users attempt to update those in the future. Also, see #448 where we decided to use a single aspect ratio on the website. If that were fixed, we might want to rework the some of the validations like - Enforce a fixed image size rather than a maximum - Remove the separate aspect ratio check all-together The current file size limit in the PR seems clearly too large. I think something like 250kb would be more appropriate, but that would require a lot more work on existing assets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.