Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added I18n strings for RPMFILTER and REBOOT_REQD flags from #1448 #1479

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

Docteh
Copy link
Contributor

@Docteh Docteh commented Jun 6, 2019

Hi, I was looking at the javascript console for other reasons, and noticed complaints about missing strings.

For RPMFILTER I copied the description from https://github.com/betaflight/betaflight/wiki/Arming-Sequence-&-Safety

@Docteh Docteh force-pushed the new_flags branch 2 times, most recently from 38138c5 to 76b4eca Compare June 6, 2019 01:49
McGiverGim
McGiverGim previously approved these changes Jun 6, 2019
Copy link
Member

@McGiverGim McGiverGim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me is ok, but usually I left the ARM_SWITCH in the latest position to use the same order here than in the tab.

Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @McGiverGim, the ordering should be preserved.

@mikeller mikeller added this to the 10.6.0 milestone Jun 6, 2019
@mikeller mikeller added the RN: UI label Jun 6, 2019
@Docteh
Copy link
Contributor Author

Docteh commented Jun 6, 2019

done

Side thought: Is the order of these preserved through the translation service? It might be worthwhile to have a reference to the translation service at the very top.

"translation_service": {
    "message": "Translation collaboration for betaflight-configurator is done on crowdin, not through github"
    "url": "https://crowdin.com/project/betaflight-configurator"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants