Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prompter arg for batch size #70

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add Prompter arg for batch size #70

merged 1 commit into from
Nov 12, 2024

Conversation

RyanMarten
Copy link
Contributor

Closes #42

batch_size is only used when batch=True

@RyanMarten RyanMarten requested a review from vutrung96 November 12, 2024 20:20
@RyanMarten RyanMarten assigned CharlieJCJ and unassigned CharlieJCJ Nov 12, 2024
@RyanMarten RyanMarten changed the base branch from dev to ryanm/response-has-request November 12, 2024 20:21
CharlieJCJ
CharlieJCJ approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RyanMarten RyanMarten merged commit 41f4ed8 into ryanm/response-has-request Nov 12, 2024
@RyanMarten RyanMarten deleted the ryanm/batch_size_arg branch November 12, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlieJCJ CharlieJCJ CharlieJCJ approved these changes

@vutrung96 vutrung96 Awaiting requested review from vutrung96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanMarten @CharlieJCJ