Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor refactoring and cleanups. #6

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Minor refactoring and cleanups. #6

merged 1 commit into from
Nov 2, 2024

Conversation

madiator
Copy link
Contributor

@madiator madiator commented Nov 2, 2024

No description provided.

@madiator madiator requested a review from RyanMarten November 2, 2024 03:00
RyanMarten
RyanMarten approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@RyanMarten RyanMarten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this cleanup!

In the future, I can do these before I merge:

  • import groups
  • adding my name to the TODO comments
  • typing for all arguments

@RyanMarten RyanMarten merged commit 5bd1dd3 into main Nov 2, 2024
@RyanMarten RyanMarten deleted the mahesh/fix branch November 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanMarten RyanMarten RyanMarten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madiator @RyanMarten