Use dill pickle to capture the execution context #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vutrung96
changed the title
CharlieJCJ
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM, suggested nested function tests since this PR also address #127 , thanks @vutrung96 !
Action Item: use mock objects in unit tests
This was
linked to
issues
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what HF relies on to capture the closure variables and global variables
We need to use recurse=True to properly capture changing global variables https://github.com/huggingface/datasets/blob/17f17b3fe7f276e1b019cca8aa651bf7c818a928/src/datasets/utils/_dill.py#L101