Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and the poem example. #117

Merged
merged 10 commits into from
Nov 15, 2024
Merged

Update README and the poem example. #117

merged 10 commits into from
Nov 15, 2024

Conversation

madiator
Copy link
Contributor

  • Add an improved example in the README that helps understand curator better.
  • Remove lots of documentation that is in poem.py, which can be moved to our docs.

@CharlieJCJ CharlieJCJ changed the base branch from main to dev November 15, 2024 03:47
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@madiator madiator requested a review from CharlieJCJ November 15, 2024 05:52
@CharlieJCJ
Copy link
Contributor

Reviewing now

@CharlieJCJ
Copy link
Contributor

Actually reviewing now 😄

@CharlieJCJ
Copy link
Contributor

image

Something fishy in UI display, I'll fix it

@CharlieJCJ
Copy link
Contributor

Ahh, need to escape this \\n instead of \n

@CharlieJCJ
Copy link
Contributor

image image

Look like this now

Copy link
Contributor

@CharlieJCJ CharlieJCJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CharlieJCJ CharlieJCJ merged commit 3a88375 into dev Nov 15, 2024
@CharlieJCJ CharlieJCJ deleted the mahesh/update_doc branch November 19, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants