fix: close file

[testwill]

No description provided.

[benhoyt]

Thanks for the fix. Out of interest, how did you find/notice this?

Note that the "defer close" needs to be before the isNewFile block, otherwise if that first write fails the file still won't be closed.

Also, because it's a file we're writing to, we need to handle and return the error from f.Close(). I suggest changing the return value to a named return value, (err error) and doing something like this:

	defer func() {
		closeErr := f.Close()
		err = errors.Join(err, closeErr)
	}()

Is there any way we can test for this? I'm guessing it won't be easy, so probably not worth it.

[testwill]

Thanks for the fix. Out of interest, how did you find/notice this?

Note that the "defer close" needs to be before the isNewFile block, otherwise if that first write fails the file still won't be closed.

Also, because it's a file we're writing to, we need to handle and return the error from f.Close(). I suggest changing the return value to a named return value, (err error) and doing something like this:

	defer func() {
		closeErr := f.Close()
		err = errors.Join(err, closeErr)
	}()

Is there any way we can test for this? I'm guessing it won't be easy, so probably not worth it.

Found by browsing the code

[benhoyt]

You forgot the (err error) named return and moving the defer up.

I fixed this and also remembered errors.Join is Go 1.20+ (currently go.mod is on 1.16) so I removed the use of that, see 1962653

[benhoyt]

Thanks again for spotting this!