Fix rare race in pipe-to-command close() result test #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juster
force-pushed
the
pipe_to_cmd_test_race
branch
from
d03f623 to
bf01e96
Compare
|
I fixed a Linux test failure which was caused by using sh's (technically bash's) |
The bufio.Writer does not write to the Cmd pipe until Flush is called when the Cmd is Wait-ed on. This causes a Flush error but not a Wait error. This only happens if the Cmd starts and exits before the Flush can be called by goawk. Fix this by forcing the spawned "sh" command to read a line of input before exiting or sending a signal to itself. Automated tests ran into another problem: The windows GitHub runner installs gawk using Chocolatey and this package of gawk does not use "sh" to execute commands, instead it uses "cmd.exe". Because "read" is a "sh" builtin command this will not work for windows tests of gawk and probably other awks.
juster
force-pushed
the
pipe_to_cmd_test_race
branch
from
bf01e96 to
0f519b8
Compare
|
I looked at this today and it was more obvious what the problem was. The I skipped the test which uses the |
benhoyt
approved these changes
Oct 16, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a fix for the test race condition in #206 and the test fail for Linux:
https://github.com/benhoyt/goawk/actions/runs/6293036690/job/17083040381.
I was able to reproduce on my older Macbook and Go 1.17 using
go test -count 1000 -run='TestInterp/^BEGIN { cmd'... but not consistently. In my case the other pipe-to-command test failed (the one which uses/bin/kill) but with the same pipe error.Analysis/commit message follows:
The bufio.Writer does not write to the Cmd pipe until Flush is called when the Cmd is Wait-ed on. This causes a Flush error but not a Wait error. This only happens if the Cmd starts and exits before the Flush can be called by goawk.