Add GitHub actions to test build on various architectures. #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to be searching relative to the location of libhmsbeagle.so When using libhmsbeagle.so in the build directory, we need to explicitly search the CPU, GPU, and JNI subdirs.
We need to be searching relative to the location of libhmsbeagle.so When using libhmsbeagle.so in the build directory, we need to explicitly search the CPU, GPU, and JNI subdirs.
Avoid converting thisS to int until we have to. Its possible that the value is larger than INT_MAX.
Fix problem computing m and s on Linux
Exception specifications were deprecated in C++11 and removed in C++17.
|
@bredelings I don't have real (good) comments but I want to appreciate your work. These are great fixes and improvements for action and the general beagle (we have been struggling with the flags recently ever since it exceeds 32..). |
xji3
reviewed
Feb 14, 2024
xji3
reviewed
Feb 14, 2024
That was painful.
bredelings
force-pushed
the
github-actions
branch
from
33c0534 to
a605944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the previous one. The first few commits are from the previous PR.
The PR:
long long.One tricky thing was that the sizes of
int,long int, andlong long intare different on mac, linux, and windows.intis 64-bit on mac, but 32-bit on linux and windowslong intis 64-bit on mac and linux, but 32-bit on windowslong long intis 64-bit everywhere.@xji3 added a new feature flag BEAGLE_FLAG_COMPUTATION_ACTION at bit 40. So this means that we need a 64-bit flags object. No change was necessary on Mac, but windows needed
long long. I suspect that this would need a version bump, as it is an API change on Mac, and an ABI change on Linux and Windows.Since I don't actually have a Mac or Windows machine, I am hoping that using github actions tests can help me avoid breaking other architectures. I'm not sure what kind of tests people would like, so please let me know.
Thoughts? (I am happy to change or reorganize things if people don't like the way I did it.)