High-Level OpenPGP API #1911
Draft
High-Level OpenPGP API #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanitasvitae
force-pushed
the
valiadateAPI
branch
from
99a1b3d to
ea5cde9
Compare
vanitasvitae
force-pushed
the
valiadateAPI
branch
3 times, most recently
from
c5856b5 to
b096e10
Compare
|
This PR is now based on #1926 |
|
This PR contains #1931 and may need to be rebased if the other patch is merged. |
…set critical packets Some signature subpackets are required by the spec to be set as critical. This patch adds overloaded methods for adding those packets with criticality set to true by default
This method can be used to make sure, that for example a v6 key cannot use ElGamal
* Rename masterKey -> primaryKey * Add generics to list structures * sanitize primary and subkeys * properly instantiate signature generators by passing key version
This class contains methods for checking properties of public key algorithms
Both the BcAEADSecretKeyEncryptorBuilder and JcaAEADSecretKeyEncryptorBuilder did not share a common super type. This patch added AEADSecretKeyEncryptorBuilder for this purpose.
The purpose of this class is to have a common factory type which can be shared by both classic CFB-based secret key encryptors, as well as newly introduced AEAD-based secret key encryptor classes. Both types can as always be implemented with Bc and JcaJce
The purpose of this class is to act as a common interface for providers for PGPContentSignerBuilders
This class provides an easy API for generating different asymmetric keys which can be used to construct OpenPGP keys. This patch introduces both the PGPKeyPairGenerator itself, as well as an abstract PGPKeyPairGeneratorProvider and two concrete implementations for BC and JCAJCE. It also adds a test
Contains the fix from bcgit#1882
vanitasvitae
force-pushed
the
valiadateAPI
branch
from
c83aa87 to
bfec434
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a high-level API for OpenPGP, which simplifies the following tasks:
OpenPGPMessageGeneratorsets up anOpenPGPMessageOutputStreambased on user configurationOpenPGPMessageProcessorprocesses encrypted / signed / compressed OpenPGP messages and emits the plaintext along with metadataOpenPGPCertificateacts as high-level API pendant toPGPPublicKeyRing, evaluating expiration / revocation / key signatures and allows the user to get verified information about the certOpenPGPKeyprovides similar high-level API pendant toPGPSecretKeyRingI decided to use a common
OpenPGP*naming scheme for the new HighLevel API classes and also decided to make use of general terminology from the book "OpenPGP for application developers" (https://openpgp.dev).This PR is still pretty much very early work in progress (as is #1857, which will eventually integrate with this API), but I want you to be able to comment on it during the development phase already :)