Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbolic macros #267

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

tetromino
Copy link
Collaborator

Note that since starlark_doc_extract proto output for symbolic macros is incomplete in Bazel 8.0, finalizers and inherited attributes only get documented when using Bazel at HEAD.

Inherited natively-defined attributes frequently lack doc strings, so we have to synthesize something reasonable - if possible, with a link to the Bazel's common attribute table.

Note that since starlark_doc_extract proto output for symbolic macros
is incomplete in Bazel 8.0, finalizers and inherited attributes only
get documented when using Bazel at HEAD.

Inherited natively-defined attributes frequently lack doc strings, so
we have to synthesize something reasonable - if possible, with a link
to the Bazel's common attribute table.
@tetromino tetromino requested a review from brandjon as a code owner December 1, 2024 04:08
@tetromino tetromino marked this pull request as draft December 1, 2024 04:08
@tetromino
Copy link
Collaborator Author

TODO: add symbolic macros to table of contents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant