Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaInfo provider should be given for deps #774

Merged
merged 3 commits into from
Jul 17, 2019
Merged

JavaInfo provider should be given for deps #774

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d255404
a JavaInfo provider should be given for deps
long-stripe Jun 19, 2019
5de16b5
flatten providers lists
long-stripe Jun 20, 2019
d9f9fe8
Revert "flatten providers lists"
long-stripe Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions scala/scala.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,13 @@ _common_attrs_for_plugin_bootstrapping = {
".srcjar",
".java",
]),
"deps": attr.label_list(aspects = [
_collect_plus_one_deps_aspect,
_coverage_replacements_provider.aspect,
]),
"deps": attr.label_list(
aspects = [
_collect_plus_one_deps_aspect,
_coverage_replacements_provider.aspect,
],
providers = [[JavaInfo]],
),
"plugins": attr.label_list(allow_files = [".jar"]),
"runtime_deps": attr.label_list(providers = [[JavaInfo]]),
"data": attr.label_list(allow_files = True),
Expand Down Expand Up @@ -695,4 +698,4 @@ def scala_specs2_junit_test(name, **kwargs):
**kwargs
)

scala_doc = _scala_doc
scala_doc = _scala_doc