Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated java_stub_template in scala_repositories #723

Merged
merged 3 commits into from
Mar 27, 2019
Merged

Conversation

ittaiz
Copy link
Member

@ittaiz ittaiz commented Mar 27, 2019

adding it to the WORKSPACE was wrong since now each user needs to do the same action (and we have two contradicting declarations)

@ittaiz ittaiz requested a review from johnynek as a code owner March 27, 2019 16:49
@ittaiz
Copy link
Member Author

ittaiz commented Mar 27, 2019

@johnynek I think I was mistaken in adding the java_stub_template directly to the workspace.
This approach seems wiser.

@ittaiz
Copy link
Member Author

ittaiz commented Mar 27, 2019

thanks! I'll merge it when green. Want to customize the commit message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants