Add test for editing patch Cargo.toml files #3063
Open
+73
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
patch-edit-test
branch
3 times, most recently
from
6d49921 to
ae3936b
Compare
This tests that the repository rules are properly invalidated when patched Cargo.toml files are edited.
illicitonion
force-pushed
the
patch-edit-test
branch
from
ae3936b to
9bc6639
Compare
UebelAndre
requested changes
Dec 9, 2024
| crate_universe_local_path_in_tree: | ||
| name: Crate Universe Local Path In Tree | ||
| platform: ubuntu2004 | ||
| working_directory: examples/crate_universe_local_path | ||
| run_targets: | ||
| - "//:vendor_lazy_static_in_tree" | ||
| test_targets: |
There was a problem hiding this comment.
Why delete test_targets?
There was a problem hiding this comment.
The run script now does the bazel test an part of an integration test, and it doesn't seem useful doing the test twice
UebelAndre
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests that the repository rules are properly invalidated when patched Cargo.toml files are edited.