Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: output generated proto sources and descriptor set #2992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattem
Copy link
Contributor

@mattem mattem commented Nov 8, 2024

Adds the generated sources to an output group of the rust_prost_library so that they can be fetched by another rule, perhaps for using with write_source_files for checkin in generated files.

@mattem mattem marked this pull request as draft November 8, 2024 20:23
@mattem mattem force-pushed the output_groups_prost branch from 495846a to 49e92b4 Compare November 8, 2024 20:26
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks!

I'm happy to merge if you un-draft

@mattem mattem marked this pull request as ready for review November 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants