Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bzlmod for managing external dependencies #2181

Open
meteorcloudy opened this issue Oct 6, 2023 · 0 comments
Open

Migrate to Bzlmod for managing external dependencies #2181

meteorcloudy opened this issue Oct 6, 2023 · 0 comments

Comments

@meteorcloudy
Copy link
Member

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check bazelbuild/bazel#18958

Related issue: #1493

illicitonion pushed a commit that referenced this issue Oct 6, 2023
This will help make sure [Bazel Downstream
Pipeline](https://github.com/bazelbuild/continuous-integration/blob/master/docs/downstream-testing.md)
is green after enabling Bzlmod at Bazel@HEAD

See
bazelbuild/bazel#18958 (comment)

Related issue: #2181
nickgooding added a commit to nickgooding/rules_rust that referenced this issue Oct 10, 2023
With bzlmod enabled, errors like the following would occur:
Error in analysis_test_transition: invalid transition output '@[unknown repo '' requested from @bazel_skylib~1.3.0]//:clippy_flags': no repo visible as @ from repository '@bazel_skylib~1.3.0'

To resolve this, use str(Label("...")) to get the canonical label to use
as the key in config_settings.

Related issues: bazelbuild#2181, bazelbuild/bazel#19286
UebelAndre added a commit that referenced this issue Oct 11, 2023
With bzlmod enabled, errors like the following would occur:
```
Error in analysis_test_transition: invalid transition output '@[unknown repo '' requested from @bazel_skylib~1.3.0]//:clippy_flags': no repo visible as @ from repository '@bazel_skylib~1.3.0'
```

To resolve this, use str(Label("...")) to get the canonical label to use
as the key in config_settings.

Related issues: #2181, bazelbuild/bazel#19286

---------

Co-authored-by: UebelAndre <[email protected]>
UebelAndre pushed a commit that referenced this issue Nov 14, 2023
…#2256)

Add machinery to automatically push GitHub releases to bazel central
registry. This will need some setup by the ruleset maintainers to enable
the GitHub app when bzlmod support is ready. See the
[instructions](https://github.com/apps/publish-to-bcr) for more details

Ref #2181
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
This PR provides documentation of Bazelmod and several code examples
that addresses a number of issues related to Bazelmod.

Preview of the documentation:
https://github.com/marvin-hansen/rules_rust/blob/main/docs/crate_universe_bzlmod.md

First and foremost it paves the way for a meaningful update the Bazelmod
documentation that references these and existing code examples. This
touches at least the following issues:
* #2670
* #2181


The compile_opt example addresses or resolves:
*  #515
* #2701

The musl_cross_compilling example addresses or resolves
* #390 
* #276

The oci_container does not relate to any open issue, 
although the tokio example in it gives a nice end to end example so 
this definitely helps those looking for something non-trivial.

The proto example addresses or resolves:
*  #2668
*  #302
* #2534
* Possibly a few more if I were to search longer

Formalities
* I've signed the CLA
* I've signed all commits

---------

Signed-off-by: Marvin Hansen <[email protected]>
Co-authored-by: Daniel Wagner-Hall <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
Relates to:
- #2181
github-merge-queue bot pushed a commit that referenced this issue Dec 4, 2024
Additional Changes:
- The rules `rules_nodejs` for `rules_rust_wasm_bindgen` will no longer
tested and will be dropped unless bzlmod support is added for the
original `bazel_build_rules_nodejs` rules.
- `rules_rust_bindgen` updated default clang version to 17.0.3 to match
bzlmod available version.
- `rules_rust_prost` updated protobuf version to `v28.3`

Relates to:
- #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants