Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bazel version to 7.1.2, update lock file, fix no bzlmod builds #217

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

comius
Copy link
Collaborator

@comius comius commented Jun 17, 2024

No description provided.

@comius comius requested a review from a team as a code owner June 17, 2024 09:36
@comius comius added the ready to pull Required label for automatic import to Google label Jun 17, 2024
@comius comius requested review from bellspice and meteorcloudy June 17, 2024 09:38
@meteorcloudy
Copy link
Member

You can maybe add --lockfile_mode=error in the CI build to prevent it from going out-of-date.

meteorcloudy
meteorcloudy previously approved these changes Jun 17, 2024
meteorcloudy
meteorcloudy previously approved these changes Jun 17, 2024
@meteorcloudy
Copy link
Member

Ah, probably not for the last_green jobs since the Bazel version used could affect the lockfile. And for the same reason, you can add a .bazelversion file to pin the Bazel version to ensure the lockfile won't go out of date automatically when a new Bazel version is released.

@comius comius removed the ready to pull Required label for automatic import to Google label Jun 17, 2024
@comius comius changed the title Update lock file Fix Bazel version to 7.1.2, update lock file, fix no bzlmod builds Jun 17, 2024
@comius comius requested a review from meteorcloudy June 17, 2024 13:24
@comius comius merged commit db09d58 into bazelbuild:main Jun 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants