Fix duplicate worker console output #561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ByteArrayOutputStream
isn't being reset between worker instances which causes the output to be repeated as workers finish and return their response. This approach has the unfortunate downside of there being the potential for mangled outputs as multiple work requests are running/finishes at the same time.A thread safe
ByteArrayOutputStream
would be in order if we want to preserve the logs from being mangled, but it wouldn't prevent cross contamination of outputs between work requests.Alternatively if we'd like to perfectly preserve the console logs, we'd need to create a
ByteArrayOutputStream
per work request that can be written to instead of relying onSystem#out
andSystem#err
.