Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call System.gc between work requests #558

Merged
merged 3 commits into from
Jul 21, 2021
Merged

Call System.gc between work requests #558

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76c8a30
Call System.gc between work requests
Bencodes Jul 20, 2021
7a6b37e
Mirror the Bazel worker implementation with CpuTimeBasedGcScheduler
Bencodes Jul 20, 2021
d7d4dc8
Add link to the source file
Bencodes Jul 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/kotlin/io/bazel/worker/PersistentWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ class PersistentWorker(
.forEach { request ->
launch {
compileWork(request, io, writeChannel, execute)
//Be a friendly worker by performing a GC between compilation requests
System.gc()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring what's being done in the generic worker implementation inside of Bazel might actually be a better approach here that doesn't incur too much gc overhead. I can make those changes if folks think this is the right direction.

https://github.com/Bencodes/bazel/blob/3835d9b21ad524d06873dfbf465ffd2dfb635ba8/src/main/java/com/google/devtools/build/lib/worker/WorkRequestHandler.java#L431-L474

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found in other systems calling System.gc frequently only hurts instead of helping. Calling periodically would certainly be better, but is there other JVM GC settings that can help here instead of manually invoking GC?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious why bazel has decided to call System.gc as well - id think tuning the GC a bit more worthwhile. That said the approach you linked @Bencodes seems like a decent compromise.

}
}
}.invokeOnCompletion { writeChannel.close() }
Expand Down