Fix kt_android_local_test can't depend on testonly libraries #537
Conversation
Bencodes
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
kotlin/internal/jvm/android.bzl
Outdated
| @@ -28,6 +28,7 @@ def _kt_android_artifact( | |||
| kotlinc_opts = None, | |||
| javac_opts = None, | |||
| enable_data_binding = False, | |||
| testonly = False, | |||
There was a problem hiding this comment.
Not a big deal, but I don't think adding this is needed - both the native android.library and the _kt_jvm_library fetch it from the kwargs anyway. The only change really needed here is the one on line 101.
There was a problem hiding this comment.
Tried the suggested fix to line 101, works as intended. Is there any way to speed up the process of applying these changes (like contributing to a subject PR)?
Co-authored-by: Nikolas-LFDesigns <[email protected]>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-authored-by: Nikolas-LFDesigns <[email protected]>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-authored-by: Nikolas-LFDesigns <[email protected]>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
@cgruber @jin @restingbull @timpeut |
#536