Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kotlin compiler_release not being set #530

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented Apr 16, 2021

The Kotlin compiler release wasn't taking despite passing in a compiler_release

@Kernald
Copy link
Contributor

Kernald commented Apr 20, 2021

Looking at this, it looks like the issue is caused by the first argument here:

compiler_repostory_name = _KT_COMPILER_REPO,

which, on top of having a typo, is never actually used. Should the hard-coded _KT_COMPILER_REPO just below:

be updated to use this compiler_repository_name? This would prevent this bug from happening (in some way), as the two arguments are different types (dict vs string).

@jeffzoch
Copy link
Contributor

@restingbull does this fix releases? They were blocked on this issue right?

@restingbull
Copy link
Collaborator

@restingbull does this fix releases? They were blocked on this issue right?
Unfortunately, no. this only affects the work on bootstrapping kotlin with kotlin.

I pushed an ignore for the compose example (the breaking part), so I can roll up a release.

@restingbull restingbull merged commit 2bd13d6 into bazelbuild:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants