Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass tags to android sandwich #525

Merged
merged 1 commit into from
Apr 25, 2021
+3 −0
Merged

Pass tags to android sandwich #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions kotlin/internal/jvm/android.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def _kt_android_artifact(
kotlinc_opts = None,
javac_opts = None,
enable_data_binding = False,
tags = [],
**kwargs):
"""Delegates Android related build attributes to the native rules but uses the Kotlin builder to compile Java and
Kotlin srcs. Returns a sequence of labels that a wrapping macro should export.
Expand All @@ -44,6 +45,7 @@ def _kt_android_artifact(
exports = base_deps,
deps = deps if enable_data_binding else [],
enable_data_binding = enable_data_binding,
tags = tags,
**kwargs
)
_kt_jvm_library(
Expand All @@ -57,6 +59,7 @@ def _kt_android_artifact(
visibility = ["//visibility:private"],
kotlinc_opts = kotlinc_opts,
javac_opts = javac_opts,
tags = tags,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not passing the tags here prevents people from conditionally disabling Kotlin ABI compilation via the tags attribute

)
return [base_name, kt_name]

Expand Down