Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass strict_deps flag to java compiler in JavaBuilder flow #524

Conversation

arunkumar9t2
Copy link
Contributor

Currently disabling strict deps in Kotlin toolchain (experimental_strict_kotlin_deps = "off") has no effect when ABI jars compilation is enabled. Targets previously compiling with strict_deps disabled fails to build when ABI jars are enabled.

This PR fixes it by passing the Kotlin toolchain flag to underlying java_common.compile to unify the behavior.

@restingbull restingbull merged commit 8d98768 into bazelbuild:master Apr 11, 2021
@arunkumar9t2 arunkumar9t2 deleted the arun/pass-strict-deps-to-java-builder-flow branch April 11, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants