Isolate Kotlin compiler instances for Multiplex workers. #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the Kotlin Compiler Daemon and conversations with Jetbrains it seems that we need to set the system property `kotlin.environment.keepalive` so that parallel builds do not clobber each other. In `exec` the environment is registered as a disposable to be torn down, this system property avoids this. Switching to a new instance of the compiler for each invocation for safety. There is little state in the compiler and this doesn't affect performance.
jongerrish
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
restingbull
approved these changes
Apr 1, 2021
rockwotj
added a commit
to rockwotj/rules_kotlin
that referenced
this pull request
Jul 20, 2021
…elbuild#515)" This reverts commit b300cd8.
restingbull
pushed a commit
that referenced
this pull request
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Kotlin Compiler Daemon and conversations with Jetbrains it seems
that we need to set the system property
kotlin.environment.keepaliveso that parallel builds do not clobber each other.In
execthe environment is registered as a disposable to be torn down, this system property avoids this.Switching to a new instance of the compiler for each invocation for safety. There is little state in the compiler and this doesn't affect performance.