Fix java.version parsing (#510) #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiiches
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
|
I wasn't sure if I should add tests for this. Adding tests would require changing the visibility of the method to |
jeffzoch
reviewed
Mar 24, 2021
| val parsedMajor = Integer.parseInt(major) | ||
| return if (parsedMajor == 1) Integer.parseInt(minor) else parsedMajor | ||
| if (parsedMajor != 1) |
There was a problem hiding this comment.
this can be rewritten in the former style:
return if (parsedMajor == 1) Integer.parseInt(elements[1]) else parsedMajorThere was a problem hiding this comment.
Thanks for the review. Fixed as suggested.
eiiches
force-pushed
the
fix-java-version-parsing
branch
from
51b08b1 to
b1cc604
Compare
restingbull
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510
We can't always assume
this.trim().split('.')to have 3 elements, becausejava.versiondoes not include trailing zero elements. In other words,java.versioncan be a single number like11or15. This change fixes IndexOutOfBoundsException caused by the wrong assumption.References: