Initial support for code coverage. #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
nkoroste
reviewed
Mar 17, 2021
| @@ -891,4 +900,10 @@ def export_only_providers(ctx, actions, attr, outputs): | |||
| getattr(attr, "exports", []), | |||
| ), | |||
| ), | |||
| instrumented_files = coverage_common.instrumented_files_info( | |||
There was a problem hiding this comment.
identical code here and above, consider unifying
There was a problem hiding this comment.
I thought about how but its not super easy in a way that has value. I see now why folks tend to implement a "pipeline" pattern to of provider producers.
* `kt_jvm_test` supports coverage collection. * `kt_jvm_library` propagates transitive coverage information. This provides coverage support of Java code in `java_library` + `android_library` targets through `kt_jvm_test.` It also provides coverage support of Java code in `kt_jvm_library` when experimental_use_abi_jars is enabled. TODO: Instrument Kotlin code for coverage.
jongerrish
force-pushed
the
support_coverage
branch
from
d97ba3b to
9709dcb
Compare
restingbull
approved these changes
Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kt_jvm_testsupports coverage collection.kt_jvm_librarypropagates transitive coverage information.This provides coverage support of Java code in
java_library+android_librarytargets throughkt_jvm_test.It also provides coverage support of Java code in
kt_jvm_librarywhen experimental_use_abi_jars is enabled.TODO: Instrument Kotlin code for coverage.
Partially addresses: #300