Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass the multiple platform flag to kotlin compiler #487

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ivyspirit
Copy link
Contributor

We are building Kotlin multiple platform project, which need bazel to support building kotlin code with KMP features. -Xmulti-platform flag is needed to be passed to kotlinc compiler to avoid the compile errors.

Based on the statue of this issue there is no generic way of passing kotlinc compiler arguements. This PR add the arg to the kt_kotlinc_options so it can be enabled or disabled.

Test:
Tested with local local_repository, kmp code compile successful.
Before got error:
` error: the feature "multi platform projects" is experimental and should be enabled explicitly

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ivyspirit
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ivyspirit
Copy link
Contributor Author

@googlebot I fixed it.

@restingbull restingbull merged commit 912e294 into bazelbuild:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants