New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional source_jar #482

Merged

restingbull merged 1 commit into bazelbuild:master from Bencodes:allow-optional-source-jar-in-kt-jvm-import

Feb 17, 2021

Collaborator

Bencodes commented Feb 17, 2021 •

edited

Loading

Creating a kt_jvm_import target without source jars crashes.

Traceback (most recent call last):
        File "/private/var/tmp/_bazel_blee/499a001013731d09bffd82f8601a3161/external/io_bazel_rules_kotlin/kotlin/internal/jvm/impl.bzl", line 141, column 40, in kt_jvm_import_impl
                runfiles = ctx.runfiles(files = [artifact.class_jar, artifact.source_jar]),
Error in runfiles: at index 0 of files, got element of type NoneType, want File


          Support optional source_jar

1985e06

Bencodes requested review from cgruber, djwhang, jin, restingbull and timpeut as code owners

February 17, 2021 06:58

keith approved these changes

View reviewed changes

restingbull approved these changes

View reviewed changes

restingbull merged commit 0478588 into bazelbuild:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

restingbull restingbull approved these changes

keith keith approved these changes

cgruber Awaiting requested review from cgruber cgruber is a code owner

djwhang Awaiting requested review from djwhang

jin Awaiting requested review from jin

timpeut Awaiting requested review from timpeut

Labels

None yet