[jdeps] Support tracking IMPLICIT dependencies #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
jongerrish
force-pushed
the
handle_implicit_deps
branch
from
a1ad386 to
cdef952
Compare
restingbull
approved these changes
Jan 28, 2021
IMPLICIT dependencies. This case only manifests when there are NO explicit type references to any types in that given dependency, just that types are indirectly loaded via being a super type of an explicit dependency. Add tests for this cases as well as lambda references + return types.
jongerrish
force-pushed
the
handle_implicit_deps
branch
from
cdef952 to
a260dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tracking super types of type and of generic type declarations that are not explicitly referenced as IMPLICIT dependencies.
This case only manifests when there are NO explicit type references to
any types in that given dependency, just that types are indirectly
loaded via being a super type of an explicit dependency.
Add tests for this cases as well as lambda references + return types.