Strict dependency checking and enforcement. #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
compiled output with the Sun JDeps tool) happens only on Java classes compiled by the KotlinBuilder. i.e: Java compilation when `experimental_use_abi_jars = False`. 1. Use the existing unused `--output_deps_proto` flag which mirrors the parameter used by the Bazel JavaBuilder, this is passed to the legacy JDepsGenerator. 2. Use a separate `java_classes` output dir to separate Kotlin compiler output from Java compiler output. The JDepsGenerator now only runs on `java_classes`. 3. Merge separate Kotlin + Java Jdeps just as is done already with the new `experimental_use_abi_jars = True` flow.
jongerrish
force-pushed
the
strict_deps
branch
from
15dc00f to
b02a608
Compare
jongerrish
changed the title
jongerrish
force-pushed
the
strict_deps
branch
from
b02a608 to
7f39b76
Compare
jongerrish
force-pushed
the
strict_deps
branch
from
7f39b76 to
3a75b45
Compare
restingbull
approved these changes
Jan 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Toolchain parameter:
experimental_strict_kotlin_deps with values "off", "warn", "error"
Provides checking and enforcement if a dependency required for compilation is not explicitly listed in a targets 'deps'