Implement (experimental) unused dependency checking feature. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
jongerrish
force-pushed
the
unused_deps
branch
from
61f6800 to
b30062b
Compare
jongerrish
changed the title
jongerrish
changed the title
jongerrish
force-pushed
the
unused_deps
branch
from
b30062b to
52b8384
Compare
Kernald
reviewed
Jan 5, 2021
| val command = | ||
| """ | ||
| |$open ** Please remove the following dependencies:$close ${unusedLabels.joinToString(" ")} from $label | ||
| |$open ** You can use the following buildozer command:$close buildozer 'remove deps ${unusedLabels.joinToString(" ")}' $label |
There was a problem hiding this comment.
I'm not entirely sure what the \u001b[0m ANSI code is, but if the buildozer command matches ^buildozer '(.*)'\\s+(.*)$, ibazel can automatically run it when it sees it (see https://github.com/bazelbuild/bazel-watcher#output-runner)
There was a problem hiding this comment.
I copied these codes from Bazel's Java strict deps compiler plugin :-)
Looks like you can set any regex patterns anyway with the output runner, so should be good?
restingbull
approved these changes
Jan 8, 2021
attribute to the toolchain. Implement unused dependency checking in `JDepsMerger` tool. Collect jdeps dependency artifacts if experimental_report_unused_deps is enabled (warn/error) and pass to KotlinBuilder. Passing these inputs triggers `JDepsMerge` action for each target causing the unused deps checking logic to be executed. Currently these inputs are not used by the `KotlinBuilder` but will be required for future work implementing a reduced classpath feature. Add tests for experimental_report_unused_deps off/warn/error Enable experimental_report_unused_deps as "warn" for examples/android
jongerrish
force-pushed
the
unused_deps
branch
from
f50197e to
97beff8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDepsMergertool.JDepsMergeaction for each target causing the unused deps checking logic to be executed. Currently these inputs are not used by theKotlinBuilderbut will be required for future work implementing a reduced classpath feature.