Unify experimental java builder + abi jar flags #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
restingbull
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously using
experimental_use_abi_jarsimplied using Bazel's Java Builder for Java compilation. This PR removes the additionalexperimental_use_java_builderflag for simplicity, i.e: not having to support a mode using Bazel's Java builder but not using Kotlin ABI jars. Such a mode doesn't make much sense since JavaBuilder would produce header jars for Java sources, but Kotlin sources would result regular jars for compilation.An escape hatch still exists to work around targets that expose bugs in the ABI plugin by tagging such targets with
kt_abi_plugin_incompatible