Restingbull/compiler plugin rework #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
reviewed
Nov 16, 2020
| for jar_output in ji.outputs.jars: | ||
| jar = jar_output.class_jar | ||
| if ctx.attr.target_embedded_compiler: | ||
| jars.append(jarjar_action( |
There was a problem hiding this comment.
Nice, so you're deshading the compiler plugins and the action should be cacheable :-)
restingbull
force-pushed
the
restingbull/compiler-plugin-rework
branch
from
8cc1f9a to
e118144
Compare
cgruber
requested changes
Nov 16, 2020
src/main/kotlin/io/bazel/kotlin/builder/toolchain/KotlinToolchain.kt
Outdated
Show resolved
Hide resolved
|
Probably want to rebase from the changes from the release branch. |
restingbull
force-pushed
the
restingbull/compiler-plugin-rework
branch
2 times, most recently
from
c729940 to
84c0c6e
Compare
cgruber
reviewed
Nov 16, 2020
cgruber
reviewed
Nov 16, 2020
cgruber
approved these changes
Nov 16, 2020
added 9 commits
November 17, 2020 13:14
* require ids * indicate which phase the plugin executes: stub and compile * include plugin dependencies * allow compiler plugins to be exported via the exported_compiler_plugins * allow "bash" substitutions for plugin arguments of working directories (anvil demonstrates) Update bazel toolchains to 3.7
Update documentation
Fix .bazelignore (wonder what formatted that.) Removed merge artifact from toolchain.
restingbull
force-pushed
the
restingbull/compiler-plugin-rework
branch
from
84c0c6e to
54544c0
Compare
restingbull
force-pushed
the
restingbull/compiler-plugin-rework
branch
from
54544c0 to
33b4081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging fixes for the compiler plugins. (long overdue)
Add small optimization to skip building without sources.
First pass to sort out export vs. runtime vs neverlink.
Update examples to cover more cases.