Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Xplugin options to support multiple compiler plugins at a time #366

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

dotdat
Copy link
Contributor

@dotdat dotdat commented Sep 28, 2020

When two plugins are joined together by : in the same -Xplugin option, kotlinc does not apply these. Separating out the options appears to solve the issue.

Fixes #365

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dotdat
Copy link
Contributor Author

dotdat commented Oct 1, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@restingbull restingbull merged commit 2d7c5da into bazelbuild:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'noarg' and 'allopen' plugins fail to compile correctly when used together
3 participants