Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0 to allowed package name characters #364

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

justhecuke
Copy link
Contributor

For some unknown reason, 0 is the only alphanumeric character that wasn't recognized as in a package name. This led to odd scenarios that when you tried to compile code that had a 0 in the package name, the kotlin builder would package the code as the string before the 0 which led to some problems in auto-generated code.

For some unknown reason, `0` is the only alphanumeric character that wasn't recognized as in a package name. This led to odd scenarios that when you tried to compile code that had a `0` in the package name, the kotlin builder would package the code as the string before the `0` which led to some problems in auto-generated code.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@justhecuke
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@restingbull restingbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test, so we don't do this again?

@justhecuke
Copy link
Contributor Author

Add a test, so we don't do this again?

I added a test.

@justhecuke
Copy link
Contributor Author

@restingbull Any chance of a re-review?

@restingbull
Copy link
Collaborator

Apologies, missed the email.

@justhecuke
Copy link
Contributor Author

Apologies, missed the email.

No problem. It happens.

@justhecuke
Copy link
Contributor Author

@restingbull Do I need to do something else to get this merged?

@restingbull restingbull merged commit 73c5df8 into bazelbuild:master Sep 9, 2020
@restingbull
Copy link
Collaborator

restingbull commented Sep 9, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants