-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0 to allowed package name characters #364
Conversation
For some unknown reason, `0` is the only alphanumeric character that wasn't recognized as in a package name. This led to odd scenarios that when you tried to compile code that had a `0` in the package name, the kotlin builder would package the code as the string before the `0` which led to some problems in auto-generated code.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test, so we don't do this again?
I added a test. |
@restingbull Any chance of a re-review? |
Apologies, missed the email. |
No problem. It happens. |
@restingbull Do I need to do something else to get this merged? |
Apologies -- I forgot you can't merge it.
…On Wed, Sep 9, 2020 at 3:40 PM jyuhengwei ***@***.***> wrote:
@restingbull <https://github.com/restingbull> Do I need to do something
else to get this merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#364 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AN3VGM6GRHY6RNZGMT3JKSDSE7K3HANCNFSM4QUMM6BA>
.
|
For some unknown reason,
0
is the only alphanumeric character that wasn't recognized as in a package name. This led to odd scenarios that when you tried to compile code that had a0
in the package name, the kotlin builder would package the code as the string before the0
which led to some problems in auto-generated code.