Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android data-binding when building with Kotlin #346

Merged
merged 2 commits into from
Jul 18, 2020
Merged

Add support for Android data-binding when building with Kotlin #346

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fbdcad
Add support for Android data-binding when building with Kotlin.
BenHenning Jul 6, 2020
75301d7
Address reviewer comment by making enable_data_binding an explicit
BenHenning Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kotlin/internal/jvm/android.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def _kt_android_artifact(name, srcs = [], deps = [], plugins = [], **kwargs):
name = base_name,
visibility = ["//visibility:private"],
exports = base_deps,
deps = deps if kwargs.get('enable_data_binding', default = False) else [],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't pull from kwargs -- add the attribute and propagate as necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

**kwargs
)
_kt_jvm_library(
Expand Down