Adds support to compile using kotlin abi and java ijars. #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restingbull
requested review from
cgruber,
djwhang,
jin and
timpeut
as code owners
restingbull
added
status: in review
restingbull
force-pushed
the
abi
branch
2 times, most recently
from
c183367 to
f0ff3ab
Compare
|
I take it we're pausing this until we get resolution on the bugs in the ABI plugin? Can you update this bug with whatever things are blocking it please, @restingbull, and update its status? |
Actually, no. It's behind a flag. The pull is fine, and experimental feature could benefit from more eyes. |
restingbull
force-pushed
the
abi
branch
3 times, most recently
from
b30e9f8 to
b8e11fc
Compare
added 11 commits
May 9, 2020 13:47
…t the contract being honored. Adds BazelWorkerTest that checks the behaviours of both invocation workers and persistent.
* Restructured BazelWorker.kt for easier testing by pulling out the delegation invoker. * Changed the flag enums to be pulic and static. * Create KotlinBuilderTestComponent for retrieving configured instances for test. * Replaced the use of system user.dir with a more robust path usage.
Revert intellij overenthusiasm.
… analysis phase Add generate_jvm_service utility rule for embedding service definitions in a jar.
Add skip-code-gen to the builder jar Up the size the basic jvm test, as it times out occasionally with a full test run.
Add logic to trigger abi generation in the compile command on both the toolchain (experimental_abi_compile=True) and commandline option (--define=experimental_abi_compile=1,0)
…flow better. Issue: issue/296
added 2 commits
May 9, 2020 13:49
* Reworked the CompilationArgs to be more kotlinish Issue: rules_kotlin/issues/296
cgruber
reviewed
May 15, 2020
| @@ -152,7 +159,7 @@ public final Path writeGeneratedSourceFile(String filename, String[] lines) { | |||
| ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); | |||
| try (PrintStream outputStream = new PrintStream(byteArrayOutputStream)) { | |||
| return operation.apply(new CompilationTaskContext(info, outputStream, | |||
| instanceRoot().toAbsolutePath().toString() + File.separator), task); | |||
| instanceRoot().toAbsolutePath().toString() + File.separator), task); | |||
There was a problem hiding this comment.
That's the worst auto-formatting I've ever seen.
cgruber
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.