Fix jdeps collectTypeArguments stackoverflow error

Fixes #485
bazelbuild · Feb 18, 2021 · 51fe508 · 51fe508
1 parent 912e294
commit 51fe508
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/main/kotlin/io/bazel/kotlin/plugin/jdeps/JdepsGenExtension.kt b/src/main/kotlin/io/bazel/kotlin/plugin/jdeps/JdepsGenExtension.kt
@@ -19,7 +19,6 @@ import org.jetbrains.kotlin.descriptors.PropertyDescriptor
 import org.jetbrains.kotlin.descriptors.SourceElement
 import org.jetbrains.kotlin.descriptors.impl.LocalVariableDescriptor
 import org.jetbrains.kotlin.extensions.StorageComponentContainerContributor
-import org.jetbrains.kotlin.load.java.descriptors.JavaClassDescriptor
 import org.jetbrains.kotlin.load.java.descriptors.JavaMethodDescriptor
 import org.jetbrains.kotlin.load.java.descriptors.JavaPropertyDescriptor
 import org.jetbrains.kotlin.load.java.sources.JavaSourceElement
@@ -230,11 +229,14 @@ class JdepsGenExtension(
       collectTypeArguments(kotlinType)
     }
 
-    fun collectTypeArguments(kotlinType: KotlinType) {
+    fun collectTypeArguments(kotlinType: KotlinType, visitedKotlinTypes: MutableSet<KotlinType> = mutableSetOf()) {
+      visitedKotlinTypes.add(kotlinType)
       kotlinType.arguments.map { it.type }.forEach { typeArgument ->
         addExplicitDep(typeArgument)
         typeArgument.supertypes().forEach { addImplicitDep(it) }
-        collectTypeArguments(typeArgument)
+        if (!visitedKotlinTypes.contains(typeArgument)) {
+          collectTypeArguments(typeArgument, visitedKotlinTypes)
+        }
       }
     }
   }