Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore (limited) dynamic feature capability + introduce sample app #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oliviernotteghem
Copy link

This PR fixes (presumably obsolete) application bundle code :

  • add missing declaration of xmllint tool target. This tool is used during dynamic feature manifest.xml validation.
  • expose android_feature_module rule, so that it can be used in application bundle project.
  • add missing fused attribute. This attribute is used internally by android_feature_module rules and has to be declared.
  • fixes paths computation done by android_feature_module. Using Label() doesn't account for external usage.
  • fixes _merge_manifests default attribute value used by android_application. Current value is bogus.
  • change permissions of shell scripts used for validation purposes. They need to be executable for Bazel to run them.

A sample application is also provided to build a simple application bundle, whose dynamic feature contain one asset file (assets.txt). To build it : cd examples/bundle && bazel build app:assets

@ahumesky
Copy link
Collaborator

ahumesky commented Dec 4, 2024

Thanks, I've started importing this so we can have it for the 0.6.0 release

@ahumesky
Copy link
Collaborator

ahumesky commented Dec 5, 2024

One issue is that the bundle manifest validator relies on xmllint to extract info from the bundle manifest, and that tool is not installed on bazelci runner images (and we probably shouldn't depend on locally installed tools anyway). So we either have to find a way to get xmllint (for linux, mac, and windows), or build the minimal functionality for extracting the xml info into something in rules_android (ak probably)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants