Write R8 proguard mappings to a file #130
Conversation
rules/android_binary_internal/r8.bzl
Outdated
| @@ -104,6 +106,7 @@ def process_r8(ctx, jvm_ctx, packaged_resources_ctx, build_info_ctx, **_unused_c | |||
| name = "r8_ctx", | |||
| value = struct( | |||
| final_classes_dex_zip = dexes_zip, | |||
| proguard_mappings_file = proguard_mappings_file, | |||
There was a problem hiding this comment.
This will need to be bundled up into the AAB later either directly or by reading this file from ProguardMappingInfo.
There was a problem hiding this comment.
there's also the matter of hooking this into native android_binary's proguard map implicit output, which was just recently done for the "discrete" style dex/desugar/optimize pipeline: bazelbuild/bazel@3faa686
rules/android_binary_internal/r8.bzl
Outdated
| @@ -104,6 +106,7 @@ def process_r8(ctx, jvm_ctx, packaged_resources_ctx, build_info_ctx, **_unused_c | |||
| name = "r8_ctx", | |||
| value = struct( | |||
| final_classes_dex_zip = dexes_zip, | |||
| proguard_mappings_file = proguard_mappings_file, | |||
There was a problem hiding this comment.
there's also the matter of hooking this into native android_binary's proguard map implicit output, which was just recently done for the "discrete" style dex/desugar/optimize pipeline: bazelbuild/bazel@3faa686
rules/android_binary_internal/r8.bzl
Outdated
| @@ -73,9 +73,11 @@ def process_r8(ctx, jvm_ctx, packaged_resources_ctx, build_info_ctx, **_unused_c | |||
|
|
|||
| android_jar = get_android_sdk(ctx).android_jar | |||
| proguard_specs = proguard.get_proguard_specs(ctx, packaged_resources_ctx.resource_proguard_config) | |||
| proguard_mappings_file = ctx.actions.declare_file(ctx.label.name + "_proguard.map") | |||
There was a problem hiding this comment.
Native android_binary generates the mapping file only if proguard_generate_mapping is enabled: https://bazel.build/reference/be/android#android_binary.proguard_generate_mapping
Bencodes
force-pushed
the
patch-4
branch
3 times, most recently
from
617b91a to
978790f
Compare
Support writing R8 pg mappings out to a file.