Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Bzlmod for managing external dependencies #159

Closed
meteorcloudy opened this issue Oct 6, 2023 · 4 comments
Closed

Migrate to Bzlmod for managing external dependencies #159

meteorcloudy opened this issue Oct 6, 2023 · 4 comments

Comments

@meteorcloudy
Copy link
Member

With future Bazel LTS versions, Bzlmod will become the default system for external dependencies management.

Please consider migrating all your external dependencies in WORKSPACE to MODULE.bazel

For more information, please check bazelbuild/bazel#18958

@meteorcloudy
Copy link
Member Author

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3352#018af627-f96d-4305-bb29-8af240ab7f95
Looks like only two tests failing:

//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/apidescriptors:ExtractApiDescriptorsCommandTest FAILED in 3 out of 3 in 0.4s
//src/tools/javatests/com/google/devtools/build/android/sandboxedsdktoolbox/sdkdependenciesmanifest:GenerateSdkDependenciesManifestCommandTest FAILED in 3 out of 3 in 0.5s

@meteorcloudy
Copy link
Member Author

We need to use the Java runfiles library at

JAVATESTS_DIR.resolve(
Path.of(
"com/google/devtools/build/android/sandboxedsdktoolbox",
"apidescriptors/testlibrary/libtestlibrary.jar"));

@ted-xie
Copy link
Contributor

ted-xie commented Oct 12, 2023

Hmm, I thought that all tests under //src/tools were being run in BazelCI already (which should include a bzlmod config): https://github.com/bazelbuild/rules_android/blob/main/.bazelci/presubmit.yml#L7

Curious that there would be tests failing still.

@ted-xie
Copy link
Contributor

ted-xie commented Nov 5, 2024

We're 100% on bzlmod now, closing this.

@ted-xie ted-xie closed this as completed Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants