Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support digest functions in remote_asset API #286

Merged

Conversation

sluongng
Copy link
Contributor

@sluongng sluongng commented Jan 23, 2024

This will allow client(like Bazel) to specify the digest_function to the remote server (so that --experimental_remote_downloader could use non-SHA256 digest functions).

This is a recreation of #273 with reviewers' comment addressed

@sluongng sluongng requested a review from bergsieker as a code owner January 23, 2024 10:14
@sluongng sluongng changed the title sluongng/remote asset digest functions Support digest functions in remote_asset API Jan 23, 2024
@sluongng
Copy link
Contributor Author

cc: @mostynb @EdSchouten

@sluongng sluongng force-pushed the sluongng/remote_asset_digest_functions branch from 0dc9f1b to ec618ef Compare February 13, 2024 10:34
@sluongng sluongng force-pushed the sluongng/remote_asset_digest_functions branch from aab12be to 091fb9b Compare March 19, 2024 11:48
@bergsieker bergsieker merged commit 1f36c31 into bazelbuild:main Apr 9, 2024
1 check passed
@sluongng sluongng deleted the sluongng/remote_asset_digest_functions branch April 16, 2024 10:07
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this pull request Apr 25, 2024
A follow up from bazelbuild/remote-apis#286

Closes #21996.

PiperOrigin-RevId: 628100606
Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Apr 25, 2024
A follow up from bazelbuild/remote-apis#286

Closes bazelbuild#21996.

PiperOrigin-RevId: 628100606
Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
github-merge-queue bot pushed a commit to bazelbuild/bazel that referenced this pull request Apr 29, 2024
A follow up from bazelbuild/remote-apis#286

Closes #21996.

PiperOrigin-RevId: 628100606
Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38

Commit
618c0ab
Commit
dcfefd9
(Third party changes)

---------

Signed-off-by: iancha1992 <[email protected]>
Co-authored-by: Son Luong Ngoc <[email protected]>
Kila2 pushed a commit to Kila2/bazel that referenced this pull request May 13, 2024
A follow up from bazelbuild/remote-apis#286

Closes bazelbuild#21996.

PiperOrigin-RevId: 628100606
Change-Id: Ib37a013d704dcfd14556f7914d90c1393ef73d38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants