Improve signal handling. #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjgq
force-pushed
the
sigquit
branch
3 times, most recently
from
9015a56 to
c035526
Compare
Every signal specially recognized by Bazel that doesn't cause an immediate exit shouldn't cause Bazelisk to exit either, as this risks orphaning the Bazel process and making it uncontrollable by the terminal. (You can see this in action by sending a Ctrl-\ to Bazelisk, which causes it to immediately exit and makes it impossible to abort the still running Bazel invocation with Ctrl-C.) Note that forwarding is not necessary for a signal delivered by the terminal (i.e. through Ctrl-C or Ctrl-\) because the terminal already delivers it to the entire process group. For manually delivered signals, users should arguably know what they're doing, so let's not go out of our way to forward them. This also disables the printing of a Go stack dump upon SIGQUIT, which is unhelpful: users tend to report it in place of the far more useful Java thread dump.
fweikert
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every signal specially recognized by Bazel that doesn't cause an immediate exit shouldn't cause Bazelisk to exit either, as this risks orphaning the Bazel process and making it uncontrollable by the terminal. (You can see this in action by sending a Ctrl-\ to Bazelisk, which causes it to immediately exit and makes it impossible to abort the still running Bazel invocation with Ctrl-C.)
Note that forwarding is not necessary for a signal delivered by the terminal (i.e. through Ctrl-C or Ctrl-\) because the terminal already delivers it to the entire process group. For manually delivered signals, users should arguably know what they're doing, so let's not go out of our way to forward them.
This also disables the printing of a Go stack dump upon SIGQUIT, which is unhelpful: users tend to report it in place of the far more useful Java thread dump.