Avoid unnecessary HTTP requests for latest/last_rc #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring in bazelbuild#631 introduced a severe performance regression: With latest and last_rc the code traversed *all* GCS buckets for *every* existing Bazel version. Since we send one HTTP request per bucket, this behavior led to a significant increase in HTTP requests ( >140 instead of 2-3 requests). This commit restores the previous, correct behavior: Traversal will be stopped as soon as a matching version has been found. Moreover, this commit adds a test to prevent similar regressions in the future. Fixes bazelbuild#640 Drive-by fix: Replaced \"%s\" with %q.
1 task
ZetaMaster777
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring in #631 introduced a severe performance regression: With latest and last_rc the code traversed all GCS buckets for every existing Bazel version. Since we send one HTTP request per bucket, this behavior led to a significant increase in HTTP requests ( >140 instead of 2-3 requests).
This commit restores the previous, correct behavior: Traversal will be stopped as soon as a matching version has been found.
Moreover, this commit adds a test to prevent similar regressions in the future.
Fixes #640
Drive-by fix: Replaced "%s" with %q.